Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: save ec model xml #361

Merged
merged 2 commits into from
Jan 18, 2024
Merged

fix: save ec model xml #361

merged 2 commits into from
Jan 18, 2024

Conversation

mihai-sysbio
Copy link
Member

Main improvements in this PR:

This PR aims to resolve a bug where .xml was unnecessarily appended to a filename that already ended with .xml when saving an EC model. Also, a typo has been also fixed.

Instructions on merging this PR:

  • This PR has develop as target branch, and will be resolved with a squash-merge.
  • This PR has main as target branch, and will be resolved with a merge commit.

Copy link

This PR has been automatically tested with GH Actions. Here is the output of the tests:

 
GECKO installed, unknown version (cannot find version.txt)
Running geckoCoreFunctionTests
Done geckoCoreFunctionTests
__________

Note: In the case of multiple test runs, this post will be edited.

Copy link
Collaborator

@ae-tafur ae-tafur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@mihai-sysbio mihai-sysbio merged commit d1982df into develop Jan 18, 2024
1 check passed
@mihai-sysbio mihai-sysbio deleted the fix/save-ec-model-xml branch January 18, 2024 08:45
@mihai-sysbio mihai-sysbio mentioned this pull request Jan 24, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants